Skip to content

Comments

Update Dockerfile.cuda11.8#106

Merged
RuimingShen merged 3 commits intos2025_teamBfrom
fix-dockerfile
Feb 15, 2025
Merged

Update Dockerfile.cuda11.8#106
RuimingShen merged 3 commits intos2025_teamBfrom
fix-dockerfile

Conversation

@RuimingShen
Copy link
Collaborator

fix problem with last line, for more info regarding this problem see this link: https://stackoverflow.com/questions/61055324/docker-cannot-execute-binary-file add slack channel software fix in this file at line 63, update sdk version 4.0->4.1

fix problem with last line, for more info regarding this problem see this link: https://stackoverflow.com/questions/61055324/docker-cannot-execute-binary-file add slack channel software fix in this file at line 63, update sdk version 4.0->4.1
@RuimingShen
Copy link
Collaborator Author

RuimingShen commented Feb 13, 2025 via email

@harishkumarbalaji
Copy link
Collaborator

ok. In cuda12 docker file it also has the same issue. I will commit again for both file. Thank you for checking this branch out. Harish Kumar Balaji @.>于2025年2月12日 周三下午9:13写道:

@.
* commented on this pull request. ------------------------------ In setup/Dockerfile.cuda11.8 <#106 (comment)>: > \ No newline at end of file +ENTRYPOINT [ "/bin/bash", "-l", "-c" ] Yes as your message suggests, if we are going to run any command at the entry point, like starting the rosmaster using /bin/bash -c roscore then we can use -c. Here we are not running any command at startup. We are just starting the bash terminal so /bin/bash is enough. -c is of no use as we are not going to run any command at the entry point. Assuming you are in a professional place, in a company, it will be best practice to remove the code when it is not useful. You can keep the -l as it seems to be a best practice. Thanks for that. — Reply to this email directly, view it on GitHub <#106 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7VQYIHOO4GE4RZV345LIMT2PQEUPAVCNFSM6AAAAABXALIMQKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMJTG4ZDEMZQHA . You are receiving this because you authored the thread.Message ID: @.***>

@RuimingShen Cuda 12 docker is tested in my local. It is working as expected. Please make the changes on the Cuda11 docker file and make sure to test it.

@RuimingShen
Copy link
Collaborator Author

RuimingShen commented Feb 13, 2025 via email

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@RuimingShen RuimingShen merged commit 4b93f5f into s2025_teamB Feb 15, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants